This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Update naming modular-layout.md #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice catch, @bakura10 ! |
weierophinney
added a commit
that referenced
this pull request
Jan 28, 2016
Update naming modular-layout.md
weierophinney
added a commit
that referenced
this pull request
Jan 28, 2016
weierophinney
added a commit
that referenced
this pull request
Jan 28, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I'd suggest that we update the wording for better consistency and better reflect the fact that your App (the one merging is config), is mostly merging config of modules / standalone-libraries / non-app code (and not other app).
This better reflect the distinction between an app (which is actually the consuming code), and the reusable-code.