This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Moves the RouteResultObserverInterface back to the Expressive namespace #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch moves the `RouteResultObserverInterface` into the `Zend\Expressive` namespace. Since it is triggered by `Application`, it is an application-level responsibility, not the router's. Since the class names do not conflict, this can lead to an immediate deprecation of the original interface in the zend-expressive-router package. However, zend-expressive-zendviewrenderer will need updates so that it fulfills the new interface via its `UrlHelper` instance.
Also updates verbiage around zendframework#200, as the interface name has changed.
weierophinney
added a commit
that referenced
this pull request
Dec 3, 2015
weierophinney
added a commit
that referenced
this pull request
Dec 3, 2015
weierophinney
added a commit
to weierophinney/zend-expressive-router
that referenced
this pull request
Dec 3, 2015
This functionality was moved to zend-expressive in zendframework/zend-expressive#206.
weierophinney
added a commit
to weierophinney/zend-expressive-zendviewrenderer
that referenced
this pull request
Dec 3, 2015
Following on zendframework/zend-expressive#206, this patch updates the `UrlHelper` to implement `Zend\Expressive\RouteResultObserverInterface` instead of `Zend\Expressive\Router\RouteResultObserverInterface`, which is now deprecated.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch moves the
RouteResultObserverInterfaceinto theZend\Expressivenamespace. Since it is triggered byApplication, it is an application-level responsibility, not the router's.Since the class names do not conflict, this can lead to an immediate deprecation of the original interface in the zend-expressive-router package. However, zend-expressive-zendviewrenderer will need updates so that it fulfills the new interface via its
UrlHelperinstance.Since the interface has not been part of an official Expressive release yet, this change is backwards compatible.