Added the any() method.

[spiffyjr]

This method is useful for defining a single middleware that will respond to any of the $httpRouteMethods. For example, a Restful controller that has logic to route to the appropriate method internally:

$app->any('/foo', Api\RestfulController::class);

[samsonasik]

move ReflectionClass to use statement

[weierophinney]

@spiffyjr I agree with @samsonasik - but have a different suggestion:

• Import ReflectionProperty into the file.
• Use the following:
  php $app = $this->getApp(); $r = new ReflectionProperty($app, 'httpRouteMethods'); $r->setAccessible(true); $routeMethods = $r->getValue($app);

Since you're interested in a specific property, do reflection directly on it, instead of pulling it from class reflection. 😄

[weierophinney]

That's what the route() method already does if no HTTP method are provided.
It an I missing something about your intent?
On Aug 29, 2015 4:05 PM, "Kyle Spraggs" [email protected] wrote:

This method is useful for defining a single middleware that will respond
to any of the $httpRouteMethods. For example, a Restful controller that
has logic to route to the appropriate method internally:

$app->any('/foo', Api\RestfulController::class);

You can view, comment on, or merge this pull request online at:

#116
Commit Summary

• Added the any() method.

File Changes

• M src/Application.php
  https://github.com/zendframework/zend-expressive/pull/116/files#diff-0
  (13)
• M test/ApplicationTest.php
  https://github.com/zendframework/zend-expressive/pull/116/files#diff-1
  (20)

Patch Links:

• https://github.com/zendframework/zend-expressive/pull/116.patch
• https://github.com/zendframework/zend-expressive/pull/116.diff

—
Reply to this email directly or view it on GitHub
#116.

[spiffyjr]

Oh, honestly, I just assumed that route() required methods. I should RTFM?

[weierophinney]

@spiffyjr

Relevant docs are:

• http://zend-expressive.readthedocs.org/en/latest/application/#adding-routable-middleware

Essentially, if you only pass the route and middleware to route(), it assumes any HTTP method; you can pass null or Zend\Expressive\Router\Route::HTTP_METHOD_ANY as the third argument to specify matching all methods, too.

That said, it's more verbose than your proposed any() method for situations when you want to specify a name, which might lend weight to adding this. Thoughts?

[spiffyjr]

I'd agree. It's also similar to other frameworks where route is typically used for custom mapping, e.g., POST and PUT but not GET, etc.

[weierophinney]

@spiffyjr Can you also update the doc/book/application.md file to indicate this new method, please?

[spiffyjr]

I originally had an entire section on any() but removed in favor of this version. It's simple and the word "any" makes it obvious what it does.

[weierophinney]

Pass a null or Router\Route::HTTP_METHOD_ANY for the third argument. $httpRouteMethods only really exists to determine what methods are valid overloading methods.

[spiffyjr]

I used Router\Route::METHOD_ANY for brevity (and clarity!).

[weierophinney]

for brevity

You mean "clarity," right? :) Looks good; will merge later today!

[spiffyjr]

Dammit man, I'm a programmer not an English major. :D

[weierophinney]

@spiffyjr Looks like you need to use null, and not the Route::HTTP_METHOD_ANY constant:

• https://travis-ci.org/zendframework/zend-expressive/jobs/78406676#L195

[spiffyjr]

That's what I get for using the online editor. That's also what Travis is for! Hooray!

[weierophinney]

Still failing:

• https://travis-ci.org/zendframework/zend-expressive/jobs/78411695#L194

Essentially, you should be asserting against Route::HTTP_METHOD_ANY instead of the array of methods. (In other words, you can totally forget the ReflectionProperty stuff I mentioned in a previous comment.)

[weierophinney]

Merged to develop for release with 0.2.0.

[spiffyjr]

Having a kid at the moment so thanks for updating this.