This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
#63 no json_decode() call if request body is empty #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weierophinney
suggested changes
Jul 24, 2018
|
|
||
| if (empty($rawBody)) { | ||
| return $request | ||
| ->withAttribute('rawBody', $rawBody) |
There was a problem hiding this comment.
Why are you adding this attribute? The raw body can already be accessed via $request->getBody(), making this redundant information.
There was a problem hiding this comment.
@weierophinney Without my change, this was added as well, so i was keeping it to not introduce some kind of BC break. See: https://github.com/zendframework/zend-expressive-helpers/pull/64/files#diff-2def9921da214e2d356d90bbcf2ef2d9R60
There was a problem hiding this comment.
Hmmm... okay.
We should likely revisit that in the next major version, as we shouldn't be doing that!
There was a problem hiding this comment.
Yep, good point. I opened #65 for that.
weierophinney
approved these changes
Jul 24, 2018
2 tasks
weierophinney
added a commit
that referenced
this pull request
Jul 25, 2018
weierophinney
added a commit
that referenced
this pull request
Jul 25, 2018
Forward port #64 Conflicts: CHANGELOG.md
|
Thanks, @BreiteSeite! |
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #63
Provide a narrative description of what you are trying to accomplish:
masterbranch, and submit against that branch.CHANGELOG.mdentry for the fix.