This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
BodyParams middleware stolen w/permission from mwop.net #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weierophinney
added a commit
to weierophinney/zend-expressive-helpers
that referenced
this pull request
Dec 22, 2015
BodyParams middleware stolen w/permission from mwop.net
weierophinney
added a commit
to weierophinney/zend-expressive-helpers
that referenced
this pull request
Dec 22, 2015
This patch builds on the one in zendframework#3, moving the act of parsing a Content-Type as well as parsing the request body to *strategies*, which implement `Zend\Expressive\BodyParams\StrategyInterface`. These define two methods: - `match($contentType)`, which should accept a Content-Type header value, and return a boolean value indicating whether or not the strategy matches. - `parse(ServerRequestInterface $request)`, which should accept the request instance, parse its raw body, and return a new request instance with the results of parsing injected as the parsed body. The form and json matching/parsing were rewritten as strategies, and added as default strategies to the middleware. Custom strategies can be written and then attached using `addStrategy()`.
weierophinney
added a commit
that referenced
this pull request
Dec 22, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@weierophinney this should be a good start for what we discussed last week. I just copied what you had, tweaked the namespace/class name, added comments, and added tests.
I'm not entirely sure what you meant by "attaching other strategies" in your follow-up tweet, though. If you can give me an example, we can work it in, but it certainly fits the need in my project as-is.