This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Updated to final PSR-15 #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/AuthenticationMiddleware.php
Outdated
| @@ -1,18 +1,18 @@ | |||
| <?php | |||
| /** | |||
| * @see https://github.com/zendframework/zend-expressive-authentication for the canonical source repository | |||
| * @copyright Copyright (c) 2017 Zend Technologies USA Inc. (https://www.zend.com) | |||
| * @copyright Copyright (c) 2018 Zend Technologies USA Inc. (https://www.zend.com) | |||
| use Interop\Http\Server\MiddlewareInterface; | ||
| use Interop\Http\Server\RequestHandlerInterface; | ||
| use Psr\Http\Server\MiddlewareInterface; | ||
| use Psr\Http\Server\RequestHandlerInterface; |
There was a problem hiding this comment.
Please use alphabetical order.
| @@ -1,16 +1,16 @@ | |||
| <?php | |||
| /** | |||
| * @see https://github.com/zendframework/zend-expressive-authentication for the canonical source repository | |||
| * @copyright Copyright (c) 2017 Zend Technologies USA Inc. (https://www.zend.com) | |||
| * @copyright Copyright (c) 2018 Zend Technologies USA Inc. (https://www.zend.com) | |||
composer.json
Outdated
| "psr/http-message": "^1.0.1", | ||
| "psr/http-server-handler": "^1.0", | ||
| "psr/http-server-middleware": "^1.0", | ||
| "zendframework/zend-diactoros": "^1.7" |
There was a problem hiding this comment.
Why new dependency to zendframework/zend-diactoros here?
There was a problem hiding this comment.
There was a problem hiding this comment.
The whole point is not to have it there !
There was a problem hiding this comment.
composer.json
Outdated
| "psr/container": "^1.0", | ||
| "psr/http-message": "^1.0.1" | ||
| "psr/http-message": "^1.0.1", | ||
| "psr/http-server-handler": "^1.0", |
There was a problem hiding this comment.
We don't need it, as it is required by psr/http-server-middleware
As explained by others, there is a test in place before using Response(). If the class does not exist an exception is thrown.
michalbundyra
approved these changes
Jan 23, 2018
weierophinney
added a commit
that referenced
this pull request
Feb 7, 2018
weierophinney
added a commit
that referenced
this pull request
Feb 7, 2018
|
Thanks, @xtreamwayz! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.