This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Fixes #12 : use false result check at stmt->fetchObject() to handle username not found data ( auth failure ) #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…) to handle not found data ( auth failure )
samsonasik
changed the title
|
I've added test that demonstrates the bug, and proves the fix for invalid username ( no username found in db). |
weierophinney
added a commit
that referenced
this pull request
Jan 16, 2018
Fixes #12 : use false result check at stmt->fetchObject() to handle username not found data ( auth failure )
weierophinney
added a commit
that referenced
this pull request
Jan 16, 2018
weierophinney
added a commit
that referenced
this pull request
Jan 16, 2018
Forward port #13 Conflicts: CHANGELOG.md
|
Thanks, @samsonasik; nice patch! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug that occurs when the user provides an incorrect username (username not found in DB); currently, it generates the error "Trying to get property of non-object".
The error occurs due to incorrectly checking for a false result from a
$stmt->execute()call; this should happen against a later$stmt->fetchObject()call instead.