Support zend-expressive-authentication alpha3

[michalbundyra]

Fixes #14 by removing unused trait.

[geerteltink]

Why did you remove ^1.0?

[michalbundyra]

Check last commit and build before that commit.

…

On 24 Feb 2018, 14:11 +0000, Geert Eltink ***@***.***>, wrote: @xtreamwayz commented on this pull request. In composer.json: > @@ -26,10 +26,10 @@ "psr/container": "^1.0", "psr/http-message": "^1.0.1", "psr/http-server-middleware": "^1.0", - "zendframework/zend-expressive-authentication": "^1.0.0alpha1 || ^1.0" + "zendframework/zend-expressive-authentication": "^1.0.0alpha3" Why did you remove ^1.0? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

[geerteltink]

I agree with increasing the minimum requirement to ^1.0.0alpha3. I don't understand why you need to remove the ^1.0 constraint.

Edit: Let me explain... The build was failing because the minimum requirement was ^1.0.0alpha1, not because the ^1.0 was there. Using ^1.0 shouldn't make a difference as it is for stable releases only.

[jguittard]

How about `1.0.x-dev`?

…

Le 24 févr. 2018 à 10:27, Geert Eltink ***@***.***> a écrit : I agree with increasing the minimum requirement to ^1.0.0alpha3. I don't understand why you need to remove the ^1.0 constraint. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

[geerteltink]

How about 1.0.x-dev?

Not sure if that works with the lowest test. What we have in other expressive packages is like this:

"zendframework/zend-expressive-router": "^3.0.0alpha1 || ^3.0",.

I'd like to see some consistency across all packages :)

[jguittard]

Let’s make it happen then ^^

…

Le 24 févr. 2018 à 10:34, Geert Eltink ***@***.***> a écrit : How about 1.0.x-dev? Not sure if that works with the lowest test. What we have in other expressive packages is this: "zendframework/zend-expressive-router": "^3.0.0alpha1 || ^3.0",. I'd like to see some consistency across all packages :) — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

[michalbundyra]

It's not gonna work, please check travis build with lowest deps.

…

On 24 Feb 2018, 14:35 +0000, Julien Guittard ***@***.***>, wrote: Let’s make it happen then ^^ > Le 24 févr. 2018 à 10:34, Geert Eltink ***@***.***> a écrit : > > How about 1.0.x-dev? > > Not sure if that works with the lowest test. What we have in other expressive packages is this: > > "zendframework/zend-expressive-router": "^3.0.0alpha1 || ^3.0",. > > I'd like to see some consistency across all packages :) > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub, or mute the thread. > — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

[michalbundyra]

I've created that issue: composer/composer#7137
We will see what will be the response, maybe we are doing something wrong?

[geerteltink]

Or our numbering of alpha versions is wrong: https://semver.org/spec/v2.0.0.html#spec-item-9

Examples: 1.0.0-alpha, 1.0.0-alpha.1

[weierophinney]

I've never seen alpha, beta, or rc use anything other than `/(a|alpha|b|beta|rc)\d+/i' syntax; that semver doc is an outlier. :-/

With regards to prefer-lowest, I recall seeing that with the skeleton's alpha3 release when I was preparing it. My recollection is that it only downgraded to a previous alpha if the minimum-stability was less than alpha (i.e. "dev"). Once I'd set the stability to alpha, I no longer observed that behavior.

In the meantime, surprisingly, ^3.0.0alpha3 will also install all 3.X stable versions I discovered, so long as the minimum-stability is at least alpha.

[weierophinney]

Not sure if that works with the lowest test. What we have in other expressive packages is like this:

"zendframework/zend-expressive-router": "^3.0.0alpha1 || ^3.0",.

I'd like to see some consistency across all packages :)

That usage is the problematic usage.

As @webimpress notes (I've confirmed locally), Composer is erroneously selecting an earlier alpha release when we include the || ^3.0 constraint. It should be looking only for a stable package with that constraint, but is instead looking at any alpha releases as well; my guess is that this is due to having previously installed an alpha, or having one side of the OR constraint allow an alpha.

What works as a workaround is only including the constraint that lists the minimum alpha release we allow. What's interesting about that is that this will continue to pick up any stable releases as well, as if we'd pinned to ^3.0.0.

[weierophinney]

Thanks, @webimpress