This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Refactor Insert::values() method to properly merge values with columns #76
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attempting to use both columns() and values() together to set the columns and value for an insert object, and when passing non-associative arrays to both, as seems logically correct to be able to do,
the generated SQL query has the numeric keys of the values array overwrite the columns set from the array passed to columns().
What I would expect is that the two were properly combined. This minor
fix does that, and leaves the remaining functionality in place. For example, I'd expect that if I had the following:
That the generated SQL would be:
Without this patch, the generated SQL would be: