This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Fix isset on null values #43
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please provide unit tests |
| @@ -226,7 +226,7 @@ public function __set($name, $value) | |||
| */ | |||
| public function __unset($name) | |||
| { | |||
| if (!isset($this->columns[$name])) { | |||
| if (!$this->__isset($name)) { | |||
There was a problem hiding this comment.
Use array_key_exists() here as well; this is a case where DRY is not better, but instead adds performance overhead and indirection.
Make the same change on the __get() method, too.
|
Merged in with commit: acfb14b |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP
issetreturns false when array item value isNULL. This resulted in__unsetthrowing an exception when attempting to remove a null field from the insert clause.