This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Allow tests to run when no databases are setup #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to 2.7.1, tests ran when: - ext/pgsql was enabled - but no databases were setup for pgsql With the changes introduced to resolve zendframework#70, however, the above combination causes cascading failures across the test suite. Marking the two tests introduced to run in separate processes largely solves the issues. Updating the first test to test for a connection exception prevents a test failure when no database is setup.
weierophinney
added a commit
that referenced
this pull request
Apr 14, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to 2.7.1, tests ran when:
With the changes introduced to resolve #70, however, the above combination causes cascading failures across the test suite.
Marking the two tests introduced to run in separate processes largely solves the issues. Updating the first test to test for a connection exception prevents a test failure when no database is setup.
Fixes #97.