test number of replacements on expression considers when same variabl…

…e is used many times

src/Sql/Expression.php

@@ -143,9 +143,13 @@ public function getExpressionData()
 
         // assign locally, escaping % signs
         $expression = str_replace(self::PLACEHOLDER, '%s', $expression, $count);
-        if ($count !== $parametersCount) {
+
+        //test number of replacements without considering same variable beign used many times first, which is
+        //faster, if the test fails then resort to regex wich are slow and used rarely
+        if ($count !== $parametersCount && $parametersCount == preg_match_all('/\:[a-zA-Z0-9_]*/', $expression)) {
             throw new Exception\RuntimeException('The number of replacements in the expression does not match the number of parameters');
         }
+
         foreach ($parameters as $parameter) {
             list($values[], $types[]) = $this->normalizeArgument($parameter, self::TYPE_VALUE);
         }

test/Sql/ExpressionTest.php

@@ -166,4 +166,10 @@ public function testGetExpressionPreservesPercentageSignInFromUnixtime()
 
         $this->assertSame($expressionString, $expression->getExpression());
     }
+
+    public function testNumberOfReplacemensConsidersWhenSameVariableIsUsedManyTimes()
+    {
+        $expression = new Expression('uf.user_id = :user_id OR uf.friend_id = :user_id', ['user_id' => 1]);
+        $expression->getExpressionData();
+    }
 }