Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

Feature/docblock method chaining consistency #116

Merged
merged 1 commit into from
Dec 16, 2016
Merged

Feature/docblock method chaining consistency #116

merged 1 commit into from
Dec 16, 2016

Conversation

tdutrion
Copy link
Contributor

@tdutrion tdutrion commented Oct 7, 2016

As discussed in fluent interface return type vs return self #7193, this changes remove occurrences of class names and self keyword from the DocBlocks

@marc-mabe
Copy link
Member

interestingly the test for PHP-7.0 results in segmentation fault https://travis-ci.org/zendframework/zend-cache/jobs/165922572#L9937 :(

@tdutrion
Copy link
Contributor Author

Could it be related to an update of the apcu version? I don't use travis much, I'll keep digging, but if you think that's what it is please let me know.

@marc-mabe
Copy link
Member

Yea this looks very related. I'll try this setup at home to see if it's it.

In case it's because of APCu and unrelated to your changes I'll merge and see if I can provide a simple reproduce script to help the APCu developer.

Anyway thanks for the catch!

@marc-mabe
Copy link
Member

@tdutrion ok the segfault definitely happens with APCu-5.1.6 -> see https://bugs.php.net/bug.php?id=73286 and krakjoe/apcu#203

@sergeyklay
Copy link

Yes, just use 5.1.5:

git clone -q https://github.com/krakjoe/apcu -b v5.1.5 /tmp/apcu
cd /tmp/apcu

phpize &> /dev/null
./configure &> /dev/null

make --silent -j4 &> /dev/null
make --silent install
git clone -q https://github.com/krakjoe/apcu-bc /tmp/apcu-bc
cd /tmp/apcu-bc

phpize &> /dev/null
./configure &> /dev/null

make --silent -j4 &> /dev/null
make --silent install

apcu_bc.ini

[APCu]
extension=apcu.so

[APC]
extension=apc.so
apc.enabled=1
apc.enable_cli=1

See krakjoe/apcu#203

@marc-mabe
Copy link
Member

FYI: the APCu issue has been fixed in the latest version

@@ -22,7 +22,7 @@
* Set pattern options
*
* @param PatternOptions $options
* @return AbstractPattern
* @return $this Provides a fluent interface
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$this is not a valid return type, in terms of PHP-doc. Does any IDE actually understand that?

Copy link
Contributor Author

@tdutrion tdutrion Oct 26, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please go up in my very first message (before all the problems with apcu), and give your opinion on the issue on the zendframework repository (the thread is pretty much dead at the moment...).

I can definitely edit this PR as long as we settle on a comment that can be used throughout the codebase.

@tdutrion
Copy link
Contributor Author

tdutrion commented Nov 9, 2016

The PR has been edited to reflect the latest outcomes of the discussion :)

@tdutrion
Copy link
Contributor Author

Updated + up to date with the develop branch.

@marc-mabe marc-mabe merged commit fcf93a8 into zendframework:develop Dec 16, 2016
marc-mabe added a commit that referenced this pull request Dec 16, 2016
…g-consistency

Feature/docblock method chaining consistency
marc-mabe added a commit that referenced this pull request Dec 16, 2016
@marc-mabe marc-mabe added this to the 2.8.0 milestone Dec 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants