Skip to content
This repository has been archived by the owner on Jan 21, 2020. It is now read-only.

Migrating to api v2 #8

Closed
wants to merge 6 commits into from
Closed

Conversation

Lansoweb
Copy link
Contributor

At this moment, there is no Mailhide in api v2, so i left it untouched. As soon as they migrate this product too, we need to update this library.

Also, we need changes in ReCaptcha element for Zend\Form and Zend\Captcha\ReCaptcha for use this new service.

@Lansoweb Lansoweb mentioned this pull request Sep 22, 2015
</script>
$return = <<<HTML
<script type="text/javascript" src="{$host}.js{$langOption}" async defer></script>
<div id="recaptcha_widget" class="g-recaptcha" $data></div>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible to use classes instead of ids? Using hard-coded html ids prevents multiple instances from working properly on a page.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a matter of fact, the id is not necessary at all anymore. Just checked the official documentation and the only mandatory tag is the "g-recaptcha" as class. Will changed it. Thanks!

@crhallberg
Copy link

Awesome! Thanks!

*
* @var string
*/
const API_SECURE_SERVER = 'https://www.google.com/recaptcha/api';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this is not longer used?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Maks3w. According to the recaptcha documentation at https://developers.google.com/recaptcha/docs/display under "Automatically render the reCAPTCHA widget", the script must be used only with HTTPS.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But API SERVER still having the value http://

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True! My mistake ... Will fix it in a minute, sorry

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Maks3w Done on both urls, following the documentation (The verify url is also https).

@Maks3w
Copy link
Member

Maks3w commented Oct 28, 2015

I'll delegate to @weierophinney to decide if this should be merged

@dansullivan86
Copy link

@weierophinney whats the latest on this?

akrabat added a commit to akrabat/ZendService_ReCaptcha that referenced this pull request Feb 9, 2017
@akrabat
Copy link
Contributor

akrabat commented Feb 9, 2017

Superseded by #11

@akrabat akrabat closed this Feb 9, 2017
@Lansoweb
Copy link
Contributor Author

Lansoweb commented Feb 9, 2017

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants