-
Notifications
You must be signed in to change notification settings - Fork 16
Conversation
</script> | ||
$return = <<<HTML | ||
<script type="text/javascript" src="{$host}.js{$langOption}" async defer></script> | ||
<div id="recaptcha_widget" class="g-recaptcha" $data></div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it possible to use classes instead of ids? Using hard-coded html ids prevents multiple instances from working properly on a page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a matter of fact, the id is not necessary at all anymore. Just checked the official documentation and the only mandatory tag is the "g-recaptcha" as class. Will changed it. Thanks!
Awesome! Thanks! |
* | ||
* @var string | ||
*/ | ||
const API_SECURE_SERVER = 'https://www.google.com/recaptcha/api'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this is not longer used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Maks3w. According to the recaptcha documentation at https://developers.google.com/recaptcha/docs/display under "Automatically render the reCAPTCHA widget", the script must be used only with HTTPS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But API SERVER still having the value http://
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True! My mistake ... Will fix it in a minute, sorry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Maks3w Done on both urls, following the documentation (The verify url is also https).
I'll delegate to @weierophinney to decide if this should be merged |
@weierophinney whats the latest on this? |
Migrating to api v2
Superseded by #11 |
Thanks! |
At this moment, there is no Mailhide in api v2, so i left it untouched. As soon as they migrate this product too, we need to update this library.
Also, we need changes in ReCaptcha element for Zend\Form and Zend\Captcha\ReCaptcha for use this new service.