refactor: [email protected] migration + stories specs [ DO NOT MERGE ] #1985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ze-flo/styled-components-v6
… ze-flo/styled-components-v6
8 tasks
|
#1978 was merged. Closing. |
ze-flo
changed the title
ze-flo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds snapshot tests for stories from the following packages:
buttonsformsdropdownsdrodowns.legacydraggablemodalstypographygridloaderscolorpickerstooltipstagsnotificationsThese snapshot tests work by capturing the rendered output of each story and comparing it against a previously saved snapshot. This allows us to quickly detect any visual changes introduced by the
styled-componentsupgrade. It's expected that snapshots generated withstyled-componentsv6 will differ slightly from v5 due to the library changes. Specifically, you might observe:I've carefully reviewed and VQA'd stories with significant snapshot diffs to ensure the visual changes are acceptable and don't represent regressions. These include stories for:
formsdropdownsdrodowns.legacydraggablecolorpickersThe primary goal of this PR is to provide a safety net for the refactoring work being done in #1978, preventing any unintended visual regressions from slipping through. By verifying visual consistency, we can more confidently upgrade styled-components.