fix(chrome): provide missing useId container dependency for Sheet component
#1981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzempel
commented
Dec 2, 2024
Comment on lines
+88
to
+89
| /** Identifies the sheet */ | ||
| id?: string; |
There was a problem hiding this comment.
Even though it is a repeat from the extends, Garden documents id when there are meaningful relationships that result when provided by the consumer (compare PaneProvider).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While working on a project with Garden dependencies, I realized that
react-chromefails to install in certain environments due to a missingreact-uiddependency. This is often masked, sincereact-notificationspulls it in. Since Garden no longer recommendsreact-uidin favor of the more stableuseIdfrom@zendeskgarden/container-utilities, I updated the missing dependency and code accordingly (eventually, we'll also replaceuidin notificationsuseToast).Checklist
design updates will be Garden Designer approved (add the designer as a reviewer)npm start)renders as expected with reversed (RTL) directionrenders as expected in dark moderenders as expected with Bedrock CSS (?bedrock)tested in Chrome, Firefox, Safari, and Edge