fix(theming): getColor
shade default depends on transparency
#1979
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On filling out the new website color principles page, it came to light that default
shade
fallback rules are as follows:This PR makes those adjustments for the (highly minimal) edge case where color lookup is by
hue
only.Checklist
npm start
)renders as expected with reversed (RTL) directionrenders as expected with Bedrock CSS (?bedrock
)tested in Chrome, Firefox, Safari, and Edge