feat(dropdowns): add hasSelection prop for use with <Option type="next">
#1971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzempel
commented
Nov 14, 2024
| export const StyledField = styled.div.attrs({ | ||
| 'data-garden-id': COMPONENT_ID, | ||
| 'data-garden-version': PACKAGE_VERSION | ||
| })` | ||
| direction: ${props => (props.theme.rtl ? 'rtl' : 'ltr')}; | ||
| text-align: start; /* [1] */ |
There was a problem hiding this comment.
Took the opportunity to improve styling robustness.
|
This is a comment that makes it easier to find me ;) |
|
Hi @jzempel I checked the pattern demo and it looks great! |
ze-flo
approved these changes
Nov 15, 2024
There was a problem hiding this comment.
Should we plan on adding that example to Website?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The new
<Option hasSelection>prop adds an indication the the nested listbox contains selected options. Implementations will be expected to add accessibly hidden text to thetype="next"option, indicating that there are selected options in the nested listbox.Detail
Took the opportunity to clean up
dropdownsstorybook pattern demos:buttoncustomization directly into the top-levelMenustoryMenu&Comboboxportal stories into oneMenu& newComboboxnested stories into oneChecklist
npm start)?bedrock)