Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(colorpickers, grid, loaders, notifications, tags, tooltips): use transient props + snapshot testing [DO NOT MERGE] #1967

Draft
wants to merge 21 commits into
base: main
Choose a base branch
from
Draft

refactor(colorpickers, grid, loaders, notifications, tags, tooltips): use transient props + snapshot testing [DO NOT MERGE] #1967

wants to merge 21 commits into from
+210,466 −406

Commits on Nov 1, 2024

  1. test: add stories specs

    @ze-flo
    ze-flo committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    b2a9b86 View commit details
    Browse the repository at this point in the history

  2. test(MenuStory): update snapshot to account for bug fix

    @ze-flo
    ze-flo committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    d77d364 View commit details
    Browse the repository at this point in the history

  3. refactor(grid): use transient props

    @ze-flo
    ze-flo committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    f47c838 View commit details
    Browse the repository at this point in the history

  4. refactor(loaders): use transient props

    @ze-flo
    ze-flo committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    7fff8f2 View commit details
    Browse the repository at this point in the history

  5. refactor(colorpickers): use transient props

    @ze-flo
    ze-flo committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    e4a627a View commit details
    Browse the repository at this point in the history

  6. refactor(tooltips): use transient props

    @ze-flo
    ze-flo committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    5d44506 View commit details
    Browse the repository at this point in the history

  7. test: update stories snapshots w invalid attrs removed

    @ze-flo
    ze-flo committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    07d9f2f View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' of github.com:zendeskgarden/react-components into… 

    … ze-flo/transient-props-rest-w-stories-specs
    @ze-flo
    ze-flo committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    d8f4fed View commit details
    Browse the repository at this point in the history

  9. chore: remove unused import

    @ze-flo
    ze-flo committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    a48b8c4 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2024

  1. test: add Tags stories specs

    @ze-flo
    ze-flo committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    a4096d3 View commit details
    Browse the repository at this point in the history

  2. refactor(tags): use transient props

    @ze-flo
    ze-flo committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    5751947 View commit details
    Browse the repository at this point in the history

  3. refactor: convert to transient props, remove invalid DOM attrs

    @ze-flo
    ze-flo committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    b5b6283 View commit details
    Browse the repository at this point in the history

  4. fix: use correct syntax for nested selector (v6 prep) 

    https://styled-components.com/docs/faqs#nested-syntax-handling
    @ze-flo
    ze-flo committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    e17bd2f View commit details
    Browse the repository at this point in the history

  5. refactor(notifications toasts): use transient props

    @ze-flo
    ze-flo committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    3fc9dec View commit details
    Browse the repository at this point in the history

  6. refactor: remove unused isCompact logic

    @ze-flo
    ze-flo committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    cef4384 View commit details
    Browse the repository at this point in the history

  7. fix: typo

    @ze-flo
    ze-flo committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    f4ce060 View commit details
    Browse the repository at this point in the history

  8. fix: correct syntax for nested selectors

    @ze-flo
    ze-flo committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    253a31f View commit details
    Browse the repository at this point in the history

  9. test: update snapshot showing correct spellcheck attr

    @ze-flo
    ze-flo committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    4298782 View commit details
    Browse the repository at this point in the history

  10. fix: pass correct props

    @ze-flo
    ze-flo committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    41f698a View commit details
    Browse the repository at this point in the history

  11. test: fix mismatch

    @ze-flo
    ze-flo committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    99b301e View commit details
    Browse the repository at this point in the history

  12. fix: fix prop types

    @ze-flo
    ze-flo committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    b90cf85 View commit details
    Browse the repository at this point in the history