Merge pull request #259 from zendesk/mio/app-installations

[MI-753] Fix update of app installations to allow setting of "enabled"
zendesk · Aug 8, 2016 · 9e981a3 · 9e981a3
2 parents 0048d02 + 746a6bc
commit 9e981a3
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 5 deletions.
diff --git a/src/Zendesk/API/Resources/Core/AppInstallations.php b/src/Zendesk/API/Resources/Core/AppInstallations.php
@@ -43,6 +43,7 @@ protected function setUpRoutes()
     {
         $this->setRoutes([
             'create' => $this->resourceName . '.json',
+            'update' => $this->resourceName . '/{id}.json',
             'jobStatuses' => $this->resourceName . '/job_statuses/{job_id}.json',
             'requirements' => $this->resourceName . '/{id}/requirements.json',
         ]);
@@ -111,7 +112,15 @@ public function create(array $params, $routeKey = __FUNCTION__)
      */
     public function update($id = null, array $updateResourceFields = [], $routeKey = __FUNCTION__)
     {
-        $this->objectName = 'settings';
-        return $this->traitUpdate($id, $updateResourceFields, $routeKey);
+        if (empty($id)) {
+            $id = $this->getChainedParameter(__CLASS__);
+        }
+
+        $route = $this->getRoute($routeKey, ['id' => $id]);
+
+        return $this->client->put(
+            $route,
+            $updateResourceFields
+        );
     }
 }
diff --git a/tests/Zendesk/API/UnitTests/Core/AppInstallationsTest.php b/tests/Zendesk/API/UnitTests/Core/AppInstallationsTest.php
@@ -85,14 +85,17 @@ public function testUpdate()
     {
         $faker = Factory::create();
         $params = [
-            $faker->word => $faker->boolean(),
-            $faker->word => $faker->randomNumber(),
+            'enabled' => $faker->boolean(),
+            'settings' => [
+                $faker->word => $faker->boolean(),
+                $faker->word => $faker->randomNumber(),
+            ]
         ];
 
         $id = $faker->randomNumber();
 
         $this->assertEndpointCalled(function () use ($id, $params) {
             $this->client->appInstallations()->update($id, $params);
-        }, "apps/installations/{$id}.json", 'PUT', ['postFields' => ['settings' => $params]]);
+        }, "apps/installations/{$id}.json", 'PUT', ['postFields' => $params]);
     }
 }