Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VEG-2483] Update docs to reflect react scaffold update #18

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

JeanMarcGoepfert
Copy link
Contributor

@zendesk/vegemite

Description

Removes reference to external dependencies in a webpack file that no longer exists since the React scaffold was updated in #16.

External dependencies are now referenced from the window object directly (eg. ZAFClient)

References

Jira

Risks

  • [low] Just a README change

@JeanMarcGoepfert JeanMarcGoepfert changed the title [VEG-2483] Remove reference to webpack external dependencies [VEG-2483] Update docs Oct 1, 2024
@JeanMarcGoepfert JeanMarcGoepfert changed the title [VEG-2483] Update docs [VEG-2483] Update docs to reflect react scaffold update Oct 1, 2024
@JeanMarcGoepfert JeanMarcGoepfert force-pushed the jgoepfert-fix-react-scaffold-readme branch from 7b4af2d to e47d62e Compare October 1, 2024 00:15
@Shengming-Yan Shengming-Yan requested a review from a team October 1, 2024 01:57
@JeanMarcGoepfert JeanMarcGoepfert merged commit b9eaa6e into master Oct 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants