Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new scaffold to the react folder #16

Merged
merged 24 commits into from
Jul 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions .github/workflows/actions.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,17 +14,19 @@ jobs:
include:
- task: Lint
allow_failures: false
command: yarn lerna run lint
command: pnpm lerna run lint
- task: Test
allow_failures: false
command: yarn lerna run test
command: pnpm lerna run test
steps:
- uses: zendesk/checkout@v2
- name: Use Node.js
uses: zendesk/setup-node@v3
with:
node-version: 18.12.1
- name: Install pnpm
run: npm install -g pnpm
- name: install packages
run: yarn install
run: pnpm install
- name: ${{ matrix.env.TASK }}
run: TASK=${{ matrix.env.TASK }} ${{ matrix.command }}
run: TASK=${{ matrix.env.TASK }} ${{ matrix.command }}
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ This repo contains various scaffolds to help developers build [apps for Zendesk
### Setup
1. Clone or fork this repo
2. Change (`cd`) into the `app_scaffolds` directory
3. Run `yarn install`
3. Run `pnpm install`
4. `packages/react` contains react app scaffold. Please follow [React README](./packages/react/README.md)
5. `packages/basic` contains basic app scaffold. Please follow [Basic README](./packages/basic/README.md)

Expand Down
11 changes: 5 additions & 6 deletions lerna.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
{
"packages": [
"packages/*"
],
"version": "0.0.0",
"useWorkspaces": true
}
"packages": [
"packages/*"
],
"version": "0.0.0"
}
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"dependencies": {
"lerna": "^4.0.0"
"lerna": "^8.1.5"
},
"name": "app_scaffolds",
"private": true,
Expand Down
3 changes: 0 additions & 3 deletions packages/react/.babelrc

This file was deleted.

2 changes: 0 additions & 2 deletions packages/react/.browserslistrc

This file was deleted.

1 change: 1 addition & 0 deletions packages/react/.env.development
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
VITE_ZENDESK_LOCATION="http://localhost:3000/"
1 change: 1 addition & 0 deletions packages/react/.env.production
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
VITE_ZENDESK_LOCATION="assets/index.html"
30 changes: 30 additions & 0 deletions packages/react/.eslintrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
{
"root": true,
"env": { "browser": true, "es2020": true },
"extends": [
"eslint:recommended",
"plugin:react/recommended",
"plugin:react/jsx-runtime",
"plugin:react-hooks/recommended",
"standard",
"prettier"
],
"ignorePatterns": ["dist", "node_modules"],
"parserOptions": {
"ecmaVersion": "latest",
"sourceType": "module",
"ecmaFeatures": {
"jsx": true
}
},
"settings": { "react": { "version": "detect" } },
"rules": {
"react/prop-types": "off"
},
"overrides": [
{
"files": ["rollup/**/*.js"],
"env": { "node": true }
}
]
}
30 changes: 24 additions & 6 deletions packages/react/.gitignore
Original file line number Diff line number Diff line change
@@ -1,6 +1,24 @@
tmp/
dist/
node_modules/
coverage/
npm-debug.log
yarn-error.log
# Logs
logs
*.log
npm-debug.log*
yarn-debug.log*
yarn-error.log*
pnpm-debug.log*
lerna-debug.log*

node_modules
dist
dist-ssr
*.local

# Editor directories and files
.vscode/*
!.vscode/extensions.json
.idea
.DS_Store
*.suo
*.ntvs*
*.njsproj
*.sln
*.sw?
2 changes: 2 additions & 0 deletions packages/react/.prettierignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
node_modules/
dist/
9 changes: 9 additions & 0 deletions packages/react/.prettierrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"trailingComma": "none",
"tabWidth": 2,
"semi": false,
"singleQuote": true,
"printWidth": 120,
"bracketSpacing": true,
"endOfLine": "lf"
}
18 changes: 0 additions & 18 deletions packages/react/DEPLOY.md

This file was deleted.

Loading
Loading