Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra constraint to not load injection unless the main bundle is in derived data #52

Merged
merged 4 commits into from
Nov 15, 2018

Conversation

zenangst
Copy link
Owner

Now the bundle won't load unless the application is in derived data.

@codecov-io
Copy link

codecov-io commented Nov 15, 2018

Codecov Report

Merging #52 into master will increase coverage by 0.04%.
The diff coverage is 20%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #52      +/-   ##
=========================================
+ Coverage   27.45%   27.5%   +0.04%     
=========================================
  Files          16      16              
  Lines         437     440       +3     
=========================================
+ Hits          120     121       +1     
- Misses        317     319       +2
Impacted Files Coverage Δ
Tests/iOS+tvOS/UIApplicationDelegateTests.swift 0% <0%> (ø) ⬆️
Source/Shared/Injection.swift 27.1% <25%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42e16c2...7b3bbbf. Read the comment docs.

@zenangst zenangst merged commit b529121 into master Nov 15, 2018
@zenangst zenangst deleted the improve/not-loading-injection-in-release branch November 15, 2018 18:50
@jasonnam
Copy link

This change prevent me from loading bundle on simulator. I am using Xcode 10 and build configuration for running is set to Debug. Could you explain me more in which case the main bundle path contains products/debug in its path?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants