-
-
Notifications
You must be signed in to change notification settings - Fork 677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Server: Buffer full #2041
Comments
This usually happens when the client stalls and can't consume all the messages the server sent in a timely matter. Can this be related to high system load in your case? Luckily you can reattach to your session afterwards. |
Not sure about the load at the time of the crash. I have an 8 core macbook air, that I mostly use for some simple development during my free time. Nothing serious though. I'd be surprised if the load average goes much higher than 8-ish. But for sure, I can try to keep a close I to the load average and see if I can correlate it to any zellij crashes, |
Also, which terminal emulator are you using? |
I'm using iTerm2 |
It is happening to me too. The editor was slow, but I'm pretty sure is not a resource issue. I moved to Kitty and no issues so far. Just an update: It happened with Alacritty too. |
This potentially causes loss of done work. I have seen this happen twice within the last 2 days.
|
Until I issue a fix for this (need to investigate a little further) I can recommend as a workaround to use a GPU accelerated terminal. This likely happens because the terminal emulator doesn't read STDOUT fast enough, Using something like Alacritty should help a lot. |
I've also been experiencing this on my ryzen desktop since the last release. using:
|
I run into this a lot where I'm running zellij on a remote machine I'm connected over ssh. Local terminal emulator can be kitty or wezterm - both hit the issue. Local shell and remote shell are fish. When a build command starts spewing a number of lines I get the "Buffer full" error. Machine is running: Ubuntu SMP Tue Nov 22 19:54:14 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
Just FYI, there's a fix for this in the works: #2068 |
Alacritty. Also seeing it relatively often. Mostly when something produces a lot of output. |
I experienced the very same problem with a pile of queued |
Using ssh might increase the change to hit the error. As an workaround, try mosh inplace of ssh. |
FWIW I do everything on local machine and still hit this relatively often. And I think quite often it happens when I scroll very fast using my mouse. |
Just connect with The PR was merged, so it might be better in the next release... |
Using zellij 0.34.4 I can reproduce the "Buffer full" error using the following command: /bin/ls -l --hyperlink=always -R It reaches around line 35000 before If I drop the hyperlink option it lists all 450 000 lines correctly. ls version: ls (GNU coreutils) 8.30 |
If I get |
I was able to reproduce this error consistently, with this setup:
I run zellij nested like this bc I use it locally for tabs/panes, and remotely for sessions. Once it's setup, I run I noticed that when I don't run it nested (ie. I SSH into my server without running zellij locally first), the crash does not happen. |
No, I tried to reproduce it, but I was not able to do so yet. I would emphasize to use Windows Terminal for WSL, which can handle incoming data much faster as that also was leading to buffer full for me. It is available in the Microsoft store. Mosh is allowed to silently drop data (not even creating an offline queue on server or client etc with fallback slow but reliable mode), which I think is unacceptable. Aside, it does not support osc52 mobile-shell/mosh#637. |
Installed 0.35.2 on both local and remote, and I can no longer reproduce this bug #2041 (comment). Thank you so much!! |
I'm now at Zellij 0.36.0 and I haven't seen the reported issue for quite some time now. So perhaps this ticket can be closed now? |
Me too. Could be nice, if it is confirmed, that this specific buffer full error is logged properly to prevent silent/hidden regressions. |
@matu3ba If this specific error does reoccur, it will now properly terminate the offending clients connection and print a pretty verbose error message (See #2068 (comment)). The server will keep running in the background and can usually be reattached to. I'll close the issue now, feel free to reopen it in case it does occur again. Happy to hear it's fixed! |
Staring with Zellij 0.34.4 I get occasional crashes. I am unfortunately not able to come up with a reproducible way recreate it.
Whenever I get the crash, the only thing I see is this message
Error occurred in server:
Buffer full
Basic information
zellij --version
: 0.34.4stty size
: 46 178uname -av
: Darwin oMac 22.2.0 Darwin Kernel Version 22.2.0: Fri Nov 11 02:08:47 PST 2022; root:xnu-8792.61.2~4/RELEASE_X86_64 x86_64List of programs you interact with as,
PROGRAM --version
: output cropped meaningful, for example:zsh --version
: zsh 5.8.1 (x86_64-apple-darwin22.0)emacs --version
: GNU Emacs 28.2clang --version
: clang version 15.0.6Further information
n/a
The text was updated successfully, but these errors were encountered: