Skip to content

Commit

Permalink
fix: Ensure Fedora packages are updated during setup (#86)
Browse files Browse the repository at this point in the history
- Makes builds daily instead of weekly
- Add a note about running `sudo dnf update` when upgrading davincibox
- Adds `sudo dnf update` steps into `setup.sh`

Closes #84 
Closes #85
  • Loading branch information
zelikos authored Jun 16, 2024
1 parent d7a2367 commit 82e47aa
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build-davincibox.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ on:
branches:
- main
schedule:
- cron: '0 0 * * TUE'
- cron: '0 0 * * *'
push:
branches:
- main
Expand Down
10 changes: 10 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,16 @@ You can still run `add-davinci-launcher` separately, as either `add-davinci-laun

After installation completes, you can remove the `squashfs-root` directory.

After setup, run `sudo dnf update` in the container to ensure drivers are up to date:

```
# Distrobox
distrobox enter davincibox -- sudo dnf update
# Toolbox
toolbox run -c davincibox sudo dnf update
```

## Upgrading

Upgrading requires re-creating the davincibox container with the newest version of the image.
Expand Down
6 changes: 4 additions & 2 deletions setup.sh
Original file line number Diff line number Diff line change
Expand Up @@ -55,11 +55,13 @@ else

if [[ $container_type == "distrobox" ]]; then
distrobox create -i ghcr.io/zelikos/davincibox:latest -n davincibox
# Start up the container now after creation,
# rather than during the later steps
# Ensure packages are up-to-date in case of old container build
distrobox enter davincibox -- sudo dnf -y update
distrobox enter davincibox -- echo "davincibox initialized"
else
toolbox create -i ghcr.io/zelikos/davincibox:latest -c davincibox
# Ensure packages are up-to-date in case of old container build
toolbox run --container davincibox sudo dnf -y update
toolbox run --container davincibox echo "davincibox initialized"
fi

Expand Down

0 comments on commit 82e47aa

Please sign in to comment.