test: improve semantic detection and add a real test suite #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeke
changed the title
|
Ironically the Semantic Pull Request status for this PR is And the WIP status is pending because of a long-standing bug: wip/app#53 |
codebytere
approved these changes
Jul 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Semantic commit detection is now done with
conventional-commit-typesandparse-commit-message, two modules that adhere to the conventional commits spec.Also updated the README with some screenshots to help illustrate the behavior.
Added a test suite that exercises the GitHub API using nock. 100% test coverage!
👀 @ckerr, @jkleinsc, @codebytere. (Would formally request a review but you're not in this org)
Resolves #1
Resolves #3
Resolves #7
Resolves #13