Allow user to override the comment in the generated file #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeagle
pushed a commit
to alexeagle/rules_nodejs
that referenced
this pull request
Jun 10, 2020
alexeagle
pushed a commit
to alexeagle/rules_nodejs
that referenced
this pull request
Jun 10, 2020
|
Hey Alex! Great change! It looks like stardoc doesn't appreciate multiline default values 😕. I did some testing and it seems like wrapping I'm OK with having a custom stardoc rule_template in this project if we need to, but it would be even better if we could get it upstreamed. :-) |
|
Your change to remove the newline also makes sense, and might be even better. |
Useful if they have some specific instructions to put there about how to update it
|
Yeah I had to vendor the stardoc templates in rules_nodejs to fix a bunch of stuff :/ |
alexeagle
pushed a commit
to bazel-contrib/rules_nodejs
that referenced
this pull request
Jun 11, 2020
|
ping! |
zegl
approved these changes
Jul 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful if they have some specific instructions to put there about how to update it