-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stabilize Dart #50
base: main
Are you sure you want to change the base?
Stabilize Dart #50
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks and congrats on the progress. Yes please would you be able to use the matcher
package and keep the existing "complex map" test?
The |
Maybe we can also disable this example for Dart. |
Okay :) |
// Exclude `SerdeData::ComplexMap` from tests | ||
// because the `matcher` package used by the `test` package | ||
// doesn't support lists within tuples. | ||
if (value is SerdeDataComplexMap) {{ | ||
continue; | ||
}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've disabled SerdeData::ComplexMap
from the Dart tests as per your suggestion. I agree that this is the cleanest way to overcome the limitations of the matcher
package.
All changes in the v13
test value were reverted.
Summary
Fixes #49
sortMapEntries
for BCSTest Plan
Since the tests were already defined in Golang, I've written some extra Dart tests that follows the way Golang does.