Upstreams Aptos Labs patches #34
Conversation
Add support for nested byte vectors
|
@ma2bd I'm planning to open this PR but I'm having issues with local testing, mostly reverse-engineering the packages to be installed on the system, and the fact that the .NET versions supported in serde-generate are out of support from Microsoft. Any tips on how to setup a local test environment? Also, should I provide a patch that targets .NET 7, the currently supported version? Thanks! |
|
@gedigi Thanks for sharing your changes upstream. I think we could update the version of .NET in CI and officially in this repo. |
| @@ -186,10 +186,6 @@ where | |||
| .flatten() | |||
| .cloned() | |||
| .collect::<HashSet<_>>(); | |||
| writeln!(self.out, "#![allow(unused_imports)]")?; | |||
There was a problem hiding this comment.
I don't quite understand the motivation for this change. This seems to potentially break user code.
| @@ -65,6 +65,22 @@ public string deserialize_str() | |||
| return utf8.GetString(content); | |||
| } | |||
|
|
|||
| public ValueArray<ValueArray<byte>> deserialize_vec_bytes() { | |||
There was a problem hiding this comment.
Is this meant to be called by a modified version of the code-generator? (that we don't have here)
Why do we need this in the first place?
Summary
These changes were made by the Aptos Labs team from a fork of @novifinancial/serde-reflection. Pushing them upstream to remove dependency on forked version.