Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix performance regression when parsing bytes. #1909

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Fix performance regression when parsing bytes. #1909

merged 1 commit into from
Oct 28, 2024

Commits on Oct 25, 2024

  1. Fix performance regression when parsing bytes. 

    Turns out our improved error messages were adding additional overhead
because we were now constructing them through `fmt()` each time we
needed more data, independent of whether there was actually going to
be an error reported.

This adds a second version of `waitForInput()` that doesn't receive an
already prepared error message, but just returns false on error so
that the caller can throw itself.

Closes #1908.
    @rsmmr
    rsmmr committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    e7bc029 View commit details
    Browse the repository at this point in the history