Provide proper error message when trying access an unknown unit field. #1889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Returning `type::Unknown` instead of `type::Auto` will let the resolver process stop, allowing an already existing error message to kick in later. We were doing it this way already for structs, but not for units. This also includes a fix for a bug with finding bitfield ranges by ID, which was triggered by the change. Closes #1790.
bbannier
previously approved these changes
Oct 16, 2024
This suppresses some non-interesting follow-up errors. Closes #1792.
|
I've added one more commit to this PR that closes #1792. |
bbannier
approved these changes
Oct 16, 2024
rsmmr
added a commit
that referenced
this pull request
Oct 17, 2024
* origin/topic/robin/gh-1889-convert-params: Fix usage of `&convert` with unit's requiring parameters. Factor out logic to validate arguments given to a type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Returning
type::Unknowninstead oftype::Autowill let theresolver process stop, allowing an already existing error message to
kick in later. We were doing it this way already for structs, but not
for units.
This also includes a fix for a bug with finding bitfield ranges by ID,
which was triggered by the change.
Closes #1790.