Fix equality implementation of module UID. #1814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsmmr
previously approved these changes
Jul 30, 2024
bbannier
force-pushed
the
topic/bbannier/issue-1813
branch
2 times, most recently
from
ba23efa to
36589d5
Compare
rsmmr
reviewed
Jul 30, 2024
bbannier
force-pushed
the
topic/bbannier/issue-1813
branch
from
36589d5 to
d73a18e
Compare
We already computed a `unique` `ID` value for each module to allow declaring the same `ID` name multiple times; we however did not consistently use that value in the implementation of `module::UID` equality and hash operators which is addressed by this patch. Closes #1813.
We did this previously but stopped doing it with #1462.
While we ignore duplicate files it was still possible to erroneously add the same file multiple times to a compilation. Catch this trivial case.
bbannier
force-pushed
the
topic/bbannier/issue-1813
branch
from
d73a18e to
3985ae7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already computed a
uniqueIDvalue for each module to allowdeclaring the same
IDname multiple times; we however did notconsistently use that value in the implementation of
module::UIDequality and hash operators which is addressed by this patch.
Closes #1813.