Defer start of feature-dependent transformations to a later point. #1798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbannier
force-pushed
the
topic/bbannier/issue-1789
branch
2 times, most recently
from
a5b5abc to
382b7fa
Compare
We previously would evaluate whether a unit field or method was required by an optional feature before we had finished collecting all feature requirements. This behavior was fine when we were visiting individual modules' AST one by one, but breaks with #1462 were we changed using a single AST to hold all modules. This patch defers transformations until all feature requirements have been collected.
Bumps [3rdparty/utf8proc](https://github.com/JuliaStrings/utf8proc) from `894e810` to `5568eff`. - [Release notes](https://github.com/JuliaStrings/utf8proc/releases) - [Commits](JuliaStrings/utf8proc@894e810...5568eff) --- updated-dependencies: - dependency-name: 3rdparty/utf8proc dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
bbannier
force-pushed
the
topic/bbannier/issue-1789
branch
from
382b7fa to
59f04fa
Compare
rsmmr
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously would evaluate whether a unit field or method was required
by an optional feature before we had finished collecting all feature
requirements. This behavior was fine when we were visiting individual
modules' AST one by one, but breaks with #1462 were we changed using a
single AST to hold all modules.
This patch defers transformations until all feature requirements have
been collected.