Fix incorrect data consumption for &max-size.
#1669
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbannier
force-pushed
the
topic/bbannier/issue-1668
branch
from
5579d4f to
8044db2
Compare
rsmmr
reviewed
Feb 8, 2024
rsmmr
approved these changes
Feb 8, 2024
bbannier
force-pushed
the
topic/bbannier/issue-1668
branch
from
5804f01 to
07b0d3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would previously handle
&sizeand&max-sizealmost identical with the only difference that&max-sizesets up a slightly larger view to accomodate a sentinel. In particular, we also used identical code to set up the position where parsing should resume after such a field.This was incorrect as it is in general impossible to tell where parsing continues after a field with
&max-sizesince it does not signify a fixed view like&size. In this patch we now compute the next position for a&max-sizefield by inspecting the limited view to detect how much data was extracted.Closes #1668.