Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of %synchronize-* attributes for units in lists. #1619

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

bbannier
Copy link
Member

We previously would not detect %synchronize-at or %synchronize-from attributes if the unit was not directly in a field, i.e., we mishandled the common case of synchronizing on a unit in a list.

With this patch we now handle these attributes, regardless of how the unit appears.

Closes #1617.

@bbannier bbannier self-assigned this Dec 12, 2023
@bbannier bbannier force-pushed the topic/bbannier/issue-1617 branch from 1878e61 to 966f13d Compare December 12, 2023 16:11
@bbannier bbannier marked this pull request as ready for review December 12, 2023 16:25
@bbannier bbannier requested a review from rsmmr December 12, 2023 16:25
rsmmr
rsmmr previously approved these changes Dec 12, 2023
spicy/toolchain/src/compiler/codegen/parser-builder.cc Outdated Show resolved Hide resolved
We previously would not detect `%synchronize-at` or `%synchronize-from`
attributes if the unit was not directly in a field, i.e., we mishandled
the common case of synchronizing on a unit in a list.

With this patch we now handle these attributes, regardless of how the
unit appears.

Closes #1617.
@bbannier bbannier force-pushed the topic/bbannier/issue-1617 branch from 966f13d to 57debb2 Compare December 12, 2023 17:41
@bbannier bbannier merged commit d489ced into main Dec 12, 2023
5 of 13 checks passed
@bbannier bbannier deleted the topic/bbannier/issue-1617 branch December 12, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use of %synchronize-at unexpectedly rejected
2 participants