Disable capturing backtraces with HILTI exceptions in non-debug builds. #1578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsmmr
force-pushed
the
topic/robin/gh-1565
branch
from
736a4c2 to
1ef389c
Compare
They can be expensive to capture, and aren't used anywhere by default unless explicitly requested. We change it so that the exception class still remains ABI compatible between release and debug builds. It's the compilation settings of the code including `exception.h` that determines if a backtrace it captured. Closes #1565.
rsmmr
force-pushed
the
topic/robin/gh-1565
branch
from
1ef389c to
305588f
Compare
bbannier
previously approved these changes
Oct 23, 2023
hilti/runtime/include/exception.h
Outdated
| @@ -66,7 +92,7 @@ class Exception : public std::runtime_error { | |||
|
|
|||
| std::string _description; | |||
| std::string _location; | |||
| Backtrace _backtrace; | |||
| std::unique_ptr<Backtrace> _backtrace; // null if not available | |||
There was a problem hiding this comment.
Unless there is a clear performance win when going with allocating this on the heap I'd say go with std::optional instead here. That would avoid having to explicitly deal with std::unique_ptr not being copyable which IMO is not the semantics we want for an Exception.
hilti/runtime/include/exception.h
Outdated
Comment on lines
54
to
55
| // Note: We don't copy the backtrace here, as it's not clear what | ||
| // that would mean. |
There was a problem hiding this comment.
Shouldn't an exception be copyable, including its full state? I cannot see where outside of implementation details we care about the backtrace being unique.
awelzel
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They can be expensive to capture, and aren't used anywhere by default
unless explicitly requested.
Closes #1565.