Coercion and type fixes #1256
Merged
Coercion and type fixes #1256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Aug 15, 2022
Closed
bbannier
reviewed
Aug 15, 2022
Struct types instantiated through a constructor expression could end up not being fully set up, such as missing a type ID. This wouldn't occur in cases where the value got coerced before further use, but it could happen when the type was used directly without coercion. This easiest fix was to always force coercion for expressions of anonymous struct types; that also generally unifies how they handled. We achieve this by changing equality for anonymous struct types to compare successfully only against themselves, independent of the fields matching. Closes #1238.
This also adds comparison operators for a few types that are natural to use in maps, but didn't support it so far. In future, we could implement sortability for further types if needed. Closes #1233.
The struct type's ID could end up not making it across the Spicy-to-HILTI boundary. Closes #1234.
rsmmr
force-pushed
the
topic/robin/gh-1238-struct-ctor-fix
branch
2 times, most recently
from
bf6e16f to
1c702bb
Compare
rsmmr
force-pushed
the
topic/robin/gh-1238-struct-ctor-fix
branch
from
1c702bb to
49a09e2
Compare
bbannier
approved these changes
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ended up fixing three issues that were all related, one per commit.