Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize skip for fixed sized types and units #1640

Closed
J-Gras opened this issue Jan 8, 2024 · 0 comments · Fixed by #1646
Closed

Optimize skip for fixed sized types and units #1640

J-Gras opened this issue Jan 8, 2024 · 0 comments · Fixed by #1646
Assignees
@bbannier

Comments

@J-Gras
Copy link
Contributor

J-Gras commented Jan 8, 2024

According to @bbannier, skip generates optimized code for bytes. It would be great to apply the same optimization to fixed sized basic types like integers as well as fixed size units.
@bbannier bbannier mentioned this issue Jan 10, 2024
Merged
bbannier added a commit that referenced this issue Jan 12, 2024
@bbannier
Implement skipping for any field with known size.
8731132 
This patch adds `skip` support for fields with `&size` attribute or of
builtin type with known size. If a unit has a known size and it is
specified in a `&size` attribute this also allows to skip over unit
fields.

Closes #1640.
@bbannier bbannier self-assigned this Jan 12, 2024
bbannier added a commit that referenced this issue Jan 16, 2024
@bbannier
Implement skipping for any field with known size.
e85d269 
This patch adds `skip` support for fields with `&size` attribute or of
builtin type with known size. If a unit has a known size and it is
specified in a `&size` attribute this also allows to skip over unit
fields.

Closes #1640.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bbannier bbannier

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement skip handling for fields of fixed size zeek/spicy
2 participants
@bbannier @J-Gras