Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better JIT error handling for patterns #1250

Closed
stevesmoot opened this issue Jul 20, 2022 · 2 comments · Fixed by #1257
Closed

Better JIT error handling for patterns #1250

stevesmoot opened this issue Jul 20, 2022 · 2 comments · Fixed by #1257
Assignees
Labels
Bug Something isn't working

Comments

@stevesmoot
Copy link
Collaborator

the regexp engine only supports a small number of "character class" patterns. If you try and use one
that isnt supported (for example the larger set binpac supported, you get a very obscure error response:
jitre internal error: ccl_from_std_ccl: JRX_STD_CCL_NONE givenAbort trap: 6

With absolutely no evidence I suggest the engine is probably giving us a better error that we could catch and make more descriptive. If not, perhaps just add to the debugging/FAQ.

@stevesmoot stevesmoot changed the title berrer JIT error handling for patterns Better JIT error handling for patterns Jul 20, 2022
@bbannier bbannier added the Enhancement Improvement of existing functionality label Jul 21, 2022
@rsmmr
Copy link
Member

rsmmr commented Jul 26, 2022

Turns out it's actually the regex engine producing that and aborting. But we can fix that, I'll look into it.

printf 'xxx' | ./src/tests/retest '[[:xyz:]]'
=== Pattern: [[:xyz:]]
=== Data   : xxx

=== Standard matcher with subgroups
jitre internal error: ccl_from_std_ccl: JRX_STD_CCL_NONE givenAbort trap: 6

@rsmmr rsmmr self-assigned this Jul 26, 2022
@rsmmr rsmmr added Bug Something isn't working and removed Enhancement Improvement of existing functionality labels Aug 8, 2022
@rsmmr
Copy link
Member

rsmmr commented Aug 8, 2022

Fixed now in rsmmr/justrx#6, still needs a submodule bump.

@rsmmr rsmmr mentioned this issue Aug 10, 2022
@rsmmr rsmmr closed this as completed in 11d73d3 Aug 18, 2022
rsmmr added a commit that referenced this issue Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants