Cannot pass context as inout parameter

[bbannier]

In spicy-1.3.0 it was possible to pass a context as an inout parameter. This allowed users to work around #1059 in a supposedly forward-compatible way. That workaround is broken with spicy-1.4.1.

# analyzer.spicy
module foo;

type Ctx = unit { };

type X = unit(inout ctx: Ctx) { };

public type Y = unit {
	%context = Ctx;
	: X(self.context());
};

$ spicyc -dj analyzer.spicy
/private/var/folders/ht/vtb0rkbd4ws15vx02xdb84zw0000gn/T/foo_203c58e6432c1c5-ea163d6951a7f53a.cc:187:25: error: no matching
      conversion for functional-style cast from 'ValueReference<__hlt::foo::Ctx>' to '__hlt::foo::X'
    __transient_anon = (__hlt::foo::X((*__self).__context.derefAsValue()));
                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/private/var/folders/ht/vtb0rkbd4ws15vx02xdb84zw0000gn/T/foo_203c58e6432c1c5-ea163d6951a7f53a.cc:43:9: note: candidate
      constructor not viable: no known conversion from 'ValueReference<__hlt::foo::Ctx>' to 'const __hlt::foo::X' for 1st
      argument
        X(const X&) = default;
        ^
/private/var/folders/ht/vtb0rkbd4ws15vx02xdb84zw0000gn/T/foo_203c58e6432c1c5-ea163d6951a7f53a.cc:44:9: note: candidate
      constructor not viable: no known conversion from 'ValueReference<__hlt::foo::Ctx>' to '__hlt::foo::X' for 1st argument
        X(X&&) = default;
        ^
/private/var/folders/ht/vtb0rkbd4ws15vx02xdb84zw0000gn/T/foo_203c58e6432c1c5-ea163d6951a7f53a.cc:119:15: note: candidate
      constructor not viable: expects an l-value for 1st argument
    inline X::X(::hilti::rt::ValueReference<__hlt::foo::Ctx>& __p_ctx) : __p_ctx(std::move(__p_ctx)) {
              ^
/private/var/folders/ht/vtb0rkbd4ws15vx02xdb84zw0000gn/T/foo_203c58e6432c1c5-ea163d6951a7f53a.cc:116:15: note: candidate
      constructor not viable: requires 0 arguments, but 1 was provided
    inline X::X() {
              ^
1 error generated.
[error] spicyc: JIT compilation failed

Bisecting Spicy points to 2905477 as the commit where this broke.

[bbannier]

As a workaround one can pass the context as a reference:

type X = unit(inout ctx: Ctx&) { };