Initialize Bytes internal control block for all constructors.

`Bytes` inherits constructors from its base class. We previously would
not initialize the internal control block for these constructors so some
operations involving iterators on such `Bytes` instances would have
failed, even thought the controlled object was still valid.

With this patch we always set up the control block, no matter which
constructor is used.

Closes #1390.

(cherry picked from commit 71cff50)

hilti/runtime/include/types/bytes.h

@@ -173,9 +173,9 @@ class Bytes : protected std::string {
      */
     Bytes(std::string s, bytes::Charset cs);
 
-    Bytes(Base&& str) : Base(std::move(str)), _control(std::make_shared<Base*>(static_cast<Base*>(this))) {}
-    Bytes(const Bytes& xs) : Base(xs), _control(std::make_shared<Base*>(static_cast<Base*>(this))) {}
-    Bytes(Bytes&& xs) noexcept : Base(std::move(xs)), _control(std::make_shared<Base*>(static_cast<Base*>(this))) {}
+    Bytes(Base&& str) : Base(std::move(str)) {}
+    Bytes(const Bytes& xs) : Base(xs) {}
+    Bytes(Bytes&& xs) noexcept : Base(std::move(xs)) {}
 
     /** Replaces the contents of this `Bytes` with another `Bytes`.
      *
@@ -511,7 +511,7 @@ class Bytes : protected std::string {
 
 private:
     friend bytes::Iterator;
-    std::shared_ptr<Base*> _control;
+    std::shared_ptr<Base*> _control = std::make_shared<Base*>(static_cast<Base*>(this));
 
     void invalidateIterators() { _control = std::make_shared<Base*>(static_cast<Base*>(this)); }
 };

tests/Baseline/hilti.types.bytes.decode/output

@@ -2,3 +2,4 @@
 testing
 test��ng�
 testüng
+123�

tests/hilti/types/bytes/decode.hlt

@@ -9,4 +9,5 @@ hilti::print(b"testing".decode(hilti::Charset::ASCII));
 hilti::print(b"testüng\n".decode(hilti::Charset::ASCII));
 hilti::print(b"testüng".decode(hilti::Charset::UTF8));
 assert b"testüng".decode(hilti::Charset::UTF8) == b"testüng".decode(); # Check default
+hilti::print(b" 123\x01 ".strip().decode(hilti::Charset::ASCII));
 }