Fix not decrypting server's INITIAL packets #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
set_conn() should be about the c$conn record. Most other base scripts for protocols use set_session(), so do the same.
The original logic stopped decrypting any INITIAL packets after the first. The Firefox/cloudflare pcaps actually show that the server replies with a QUIC INITAL packet containing just ACK frames and no CRYPTO frames. Only the second QUIC INITIAL packet from the server then contains the CRYPTO frames. There's no good reason to stop decryption attempts, either we succeed down the road and then stop, or we fail and raise analyzer violations.
awelzel
force-pushed
the
topic/awelzel/fix-server-initial-with-ack
branch
from
0c34efc to
67126dc
Compare
Seem reasonable give we log the server SCID. Interestingly, the Chromium examples actually have zero length (empty) source connection IDs. I wonder if that's part of their "protocol ossification avoidance" effort.
awelzel
force-pushed
the
topic/awelzel/fix-server-initial-with-ack
branch
from
67126dc to
d5c3151
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits for a bit more information. I wanted to use quic.log as an example and these all came up :-)