Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quic: Bump maximum history length, make configurable #15

Merged

Conversation

awelzel
Copy link

@awelzel awelzel commented Oct 20, 2023

No description provided.

@awelzel
Copy link
Author

awelzel commented Oct 20, 2023

@timwoj / @ckreibich - would like to get that into 6.1. This is the change in the spicy-quic repo that in a second step would be cherry-picked into the Zeek tree after rewriting (or so my approach currently). Mind approving?

@dopheide-esnet shared a breakdown of the history field and there were many variations capped at 10 characters.

Copy link
Member

@timwoj timwoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting this into 6.1 sounds fine to me. I'm basically ok with taking any improvements to those plugins right now.

@awelzel awelzel merged commit cb599b5 into main Oct 20, 2023
3 checks passed
@awelzel awelzel deleted the topic/awelzel/longer-but-configurable-history-max-length branch October 20, 2023 18:06
awelzel added a commit to zeek/zeek that referenced this pull request Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants