Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

performance improvements for the LDAP ASN.1 analyzer #26

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

awelzel
Copy link
Contributor

@awelzel awelzel commented Oct 17, 2023

Patch merged into Zeek imported via:

$ sed 's,src/analyzer/protocol/ldap,analyzer,g' < 0003-performance-improvements-for-the-LDAP-ASN.1-analyzer.patch | git am

cc @pauldokas

@awelzel awelzel force-pushed the topic/arne.welzel/ldap-asn1-fixes branch from 39e0a6b to 2bef110 Compare October 17, 2023 15:27
@awelzel awelzel requested a review from rsmmr October 17, 2023 15:27
Copy link
Member

@rsmmr rsmmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable, though clearly Spicy is lacking something here to make this nicer/more efficient.

@awelzel
Copy link
Contributor Author

awelzel commented Oct 18, 2023

Mohan had opened an issue to add += for strings. Cross-referencing: zeek/spicy#1500

@awelzel awelzel merged commit 9dc0535 into main Oct 18, 2023
2 checks passed
@awelzel awelzel deleted the topic/arne.welzel/ldap-asn1-fixes branch October 18, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants