Use != for mtime comparison instead of >
#21036
Open
+4
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -3412,7 +3412,8 @@ async fn test_local_settings( | |||
| }); | |||
| } | |||
|
|
|||
| #[gpui::test(iterations = 10)] | |||
| // TODO(#21034): This test is flaky for some execution orders. Set iterations back to 10 once fixed. | |||
There was a problem hiding this comment.
I think we'd prefer to fix this bug as part of this PR, rather than put a TODO on it, unless there's a good reason to suppress the tests (e.g. the tests disabled on Linux due font sizing inconsistencies compared to what we get on macOS )
There was a problem hiding this comment.
Yeah, should probably just do the fix! Unfortunately it may be fairly involved, as it requires the effects of proto::UpdateBufferFile and proto::BufferSaved to be applied together rather than separately. I believe the effects of this would be hard to see in the UI since they are emitted at the same time.
This improves some behavior, but also reveals misbehavior such as #21034. See ["mtime comparison considered harmful"](https://apenwarr.ca/log/20181113) for details of why comparators other than equality/inequality should not be used with mtime.
mgsloan
force-pushed
the
fix-mtime-comparison
branch
from
e023cd2
to
bab6a64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves some behavior, but also reveals misbehavior such as #21034.
See "mtime comparison considered harmful" for details of why comparators other than equality/inequality should not be used with mtime.
Release Notes:
!=instead of>, mitigating issues described in a blog post "mtime comparison considered harmful".