Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hovered links underline not showing when using cmd_or_ctrl for multi_cursor_modifier #20949

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

remixz
Copy link

@remixz remixz commented Nov 21, 2024

I use cmd_or_ctrl for multi_cursor_modifier, but noticed that if I hovered a code reference while holding alt, it wouldn't show the underline. Instead, it would only show when pressing cmd. Looking at the code, it seems like this was just a small oversight on always checking for modifiers.secondary, instead of reading from the multi_cursor_modifier setting to determine which button was invoking link handling.


Release Notes:

  • Fixed underline when hovering a code link not showing when multi_cursor_modifier is cmd_or_ctrl

@notpeter notpeter added the cla-signed The user has signed the Contributor License Agreement label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants