macOS: Try improving legibility for dark themes and low-DPI displays #20506
+87
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
Have feedback on this plugin? Let's hear it! |
as-cii
force-pushed
the
gamma-correction
branch
from
bd6ded6
to
a80ff28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is an attempt at improving the situation on low-DPI displays. Specifically, in 8d2eb11, we switched to using a different rasterization scheme based on the color of the glyph. If the glyph color is light, we rasterize it using a black foreground and a white foreground. If it's dark, we do the opposite. This is because macOS applies a different smoothing algorithm based on the foreground color of the glyph.
We shouldn't merge this until somebody helps us confirm it fixes the issues reported in #7992.
Release Notes: