Let the project panel respond to ui_density settings #20460
Conversation
cla-bot
bot
added
the
cla-signed
Remco-Schoeman
changed the title
Remco-Schoeman
changed the title
|
Hey Remco! Thanks for working on expanding support for UI Density. There is actually an even easier way to do this: Rather than even accessing the ui_density setting you can use So you could do something like this:
And it would automatically respond to density. However the scale I have set up in Spacing doesn't go high enough to account for this case. If you can give me a day or so to update the spacing scale in a separate PR, I'd prefer for us to use that approach as it keeps the way we build UI to respond to density consistent. Alternatively, if you want to land this soon, you can use |
| h_flex().h_6().w_full().child(editor.clone()) | ||
| h_flex() | ||
| .map(|this| match ui_density { | ||
| theme::UiDensity::Comfortable => this.h_6(), |
There was a problem hiding this comment.
Let's use ui::Spacing rather than accessing the settings here!
|
Following up, I have a WIP PR up here: #20504. I'll add relevant details there. This should cover the needs of this PR however! I will land this PR today. |
…ject-panel-ui-density # Conflicts: # crates/project_panel/src/project_panel.rs
|
Hi @Remco-Schoeman , it seems whatever changes where in this PR got blown away by the merge. I'm going to set this to draft, feel free to mark it ready for review once this PR is back in shape :) |
@iamnbutler edit: Density tracking issue:
I noticed a setting in the Zed config:
unstable.ui_densitywhile looking for ways to get more text on my cheap 1920x1080 second monitor. (I already had made the font 14px instead of the default 16px.)While changing that setting to
compactit did exactly what I wanted, I noticed the Project panel didn't play along. The panel didn't shrink the vertical whitespace between items which made it look a bit too 'airy'.So, I fixed it.
The diff seems large, but it's mostly whitespace because of the indentation changes.
The actual change is pretty small:
I've tried to see if and how I could add tests for this change,
but I couldn't find an existing example for a test for a visual change like this.
Setting up such a test myself is beyond me as Rust is mostly arcane magic to me, so any assistance from somebody who does know is welcome.
Release Notes:
unstable.ui_densitysetting to apply to project panel