Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize confirmation key bindings for opening recent projects #20201

Closed

Conversation

counterleft
Copy link

This change makes the projects::OpenRecent action have the same create_new_window: false behavior as the application_menu's OpenRecent.

File->Open Recent is also affected since it is the same implementation as projects::OpenRecent binding.

Closes #17765

Release Notes:

  • Made File->Open Recent..., Burger Menu (Project > Open Recent Projects), and the projects: open recent command have the same key binding for 1) creating a new window or 2) reusing the existing window.

This change makes the `projects::OpenRecent` action have the same
`create_new_window: false` behavior as the `application_menu`'s OpenRecent.

`File->Open Recent` is also affected since it is the same
implementation as `projects::OpenRecent` binding.
Copy link

cla-bot bot commented Nov 4, 2024

We require contributors to sign our Contributor License Agreement, and we don't have @counterleft on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@counterleft
Copy link
Author

@cla-bot check

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Nov 4, 2024
Copy link

cla-bot bot commented Nov 4, 2024

The cla-bot has been summoned, and re-checked this pull request!

@maxdeviant maxdeviant changed the title Fixes #17765 Fix #17765 Nov 4, 2024
@maxdeviant maxdeviant changed the title Fix #17765 Standardize confirmation key bindings for opening recent projects Nov 4, 2024
@SomeoneToIgnore SomeoneToIgnore self-assigned this Nov 4, 2024
@SomeoneToIgnore
Copy link
Contributor

Fixes #17765

This is a very bad name for the PR. The one you were corrected to is much more useful.
Also, it seems that the issue mentions some other menu, not the application one?

  1. We should not do this at all, as this particular place in the menu does not have an alternative, compared to the other menu items (where one can press shift and change the behavior).

Due to this, clicking the menu will now always close the current Zed window, even if it is in the middle of the coop/shared session; moreover, Zed does not show any pop-ups/modals before doing this, so the session will be killed instantly, dropping off any clients.
This is bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
2 participants