Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic tab bar height #19076

Merged
merged 6 commits into from
Nov 16, 2024
Merged

Dynamic tab bar height #19076

merged 6 commits into from
Nov 16, 2024

Conversation

Aaron-212
Copy link
Contributor

@Aaron-212 Aaron-212 commented Oct 11, 2024 •
edited
Loading

Tracking issue: #18078

Release Notes:

  • Change tab bar height according to ui-density

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Oct 11, 2024
@zed-industries-bot
Copy link

zed-industries-bot commented Oct 11, 2024 •
edited
Loading

Messages
📖

This PR includes links to the following GitHub Issues: #18078
If this PR aims to close an issue, please include a Closes #ISSUE line at the top of the PR body.

Generated by 🚫 dangerJS against 070ca09

@Aaron-212 Aaron-212 marked this pull request as ready for review October 13, 2024 05:24
@Aaron-212 Aaron-212 changed the title [WIP] Dynamic tab bar height Dynamic tab bar height Oct 13, 2024
@SomeoneToIgnore
Copy link
Contributor

@zed-industries/design , any thoughts?

danilo-leal
danilo-leal approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet—thanks for the PR! This change seems to make sense and it hasn't affected the app visually at first glance. I'd wait for @iamnbutler's double check, though.

@Aaron-212
Copy link
Contributor Author

Rebased

@SomeoneToIgnore
Copy link
Contributor

I guess the double check will be carried on the next Nightly or so, hence merging.

@SomeoneToIgnore SomeoneToIgnore merged commit 65a9c8d into zed-industries:main Nov 16, 2024
11 checks passed
@SomeoneToIgnore SomeoneToIgnore mentioned this pull request Nov 16, 2024
Open
3 tasks
@Aaron-212 Aaron-212 deleted the comfortable-tab-bar branch November 16, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danilo-leal danilo-leal danilo-leal approved these changes

Assignees

@iamnbutler iamnbutler

@danilo-leal danilo-leal

Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Aaron-212 @zed-industries-bot @SomeoneToIgnore @danilo-leal @iamnbutler